Skip to content

Reinject doc feedback#1653

Merged
jotak merged 2 commits into
netobserv:mainfrom
jotak:reinject-doc
Jun 26, 2025
Merged

Reinject doc feedback#1653
jotak merged 2 commits into
netobserv:mainfrom
jotak:reinject-doc

Conversation

@jotak

@jotak jotak commented Jun 20, 2025

Copy link
Copy Markdown
Member

Tracking feedback from openshift/openshift-docs#94756

@jotak

jotak commented Jun 20, 2025

Copy link
Copy Markdown
Member Author

cc @gwynnemonahan

@jotak
jotak requested a review from gwynnemonahan June 20, 2025 09:36
@openshift-ci openshift-ci Bot added the lgtm label Jun 20, 2025
@gwynnemonahan

gwynnemonahan commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

LGTM

@openshift-ci openshift-ci Bot removed the lgtm label Jun 23, 2025
@openshift-ci

openshift-ci Bot commented Jun 23, 2025

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@red-hat-konflux

red-hat-konflux Bot commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
network-observability-operator-bundle-ystream-on-push json: cannot unmarshal bool into Go struct field ObjectMeta.metadata.annotations of type string
network-observability-operator-ystream-on-push json: cannot unmarshal bool into Go struct field ObjectMeta.metadata.annotations of type string

@openshift-ci

openshift-ci Bot commented Jun 23, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oliviercazade. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 23, 2025

Copy link
Copy Markdown

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator 45ff590 link false /test e2e-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jotak
jotak merged commit 0e7451c into netobserv:main Jun 26, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes
@gwynnemonahan gwynnemonahan Awaiting requested review from gwynnemonahan

Assignees

@OlivierCazade OlivierCazade

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jotak @gwynnemonahan @OlivierCazade @openshift-merge-robot